Convert outstanding files to cp1252 #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were many UTF-8 encoded files still, this change converts them to the cp1252 encoding that the game expects. For a couple files this only changes some comments, but this also fixes some actual text bugs. `HFM/localisation/0000_minimod.csv` is of note because it contained UTF-8 mojibake that was not valid cp1252. Since the invalid key came from base game files it was easy to restore it to the original characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were many UTF-8 encoded files still, this change converts them to
the cp1252 encoding that the game expects. For a couple files this only
changes some comments, but this also fixes some actual text bugs.
HFM/localisation/0000_minimod.csvis of note because it containedUTF-8 mojibake that was not valid cp1252. Since the invalid key came
from base game files it was easy to restore it to the original
characters.
When reviewing this PR, make sure you are looking at the changes with the correct encoding. For instance if using the Github web interface, your browser is likely to pick UTF-8 or fallback to auto-detection (with unpredictable results).
An example of a text bug that this PR fixes:
which was caused by:
HFM/HFM/decisions/FlavourMod_Africa.txt
Lines 1710 to 1712 in 38ca75c